@lieryan I plan no more commits to this branch.

@edreamleo thanks for doing this.

Maybe rather than adding comments about the full import qualification, we should just document this centrally?

I'd recommend a new section in docs/contributing.rst describing the rationale for the seemingly "consistently inconsistent" import style. It should say that we defaults to one level import style, and it should document the list of modules that should use full import qualifications. Then can we remove the inline comments. All this can be done in a separate PR.

@lieryan But who reads "central" documentation? I like to document the code in place if it's not too odious.

@lieryan I see you have already updated master, so I'll use your suggested code.

@lieryan I'm good with this PR now.

We could quibble about exactly when to use full qualification, but who would want to do that :-)

Import style consistency is nice, but I'm personally not too fussed if sometimes we forget about it and a couple non compliant imports slipped in 🤷‍♂️.

If necessary, in the future, we can write a pre-commit/GHA script to enforce the import style. So that it'll always be consistent without needing the comments.

It seems like it can be a useful capability for findsimilar/restructuring as well to be able to create search patterns that matches imports based on their style. But we're all ast experts here 😉, seems like a simple checker can even be just a simple standalone script.

Though I think I'm getting too much into ideas mode here, let's pull back before I get in too deep into this.

We could quibble about exactly when to use full qualification, but who would want to do that :-)

Agreed, the comments are fine as is for now, it's not a blocker for this PR.